ansible: update benchmark/v8 roles for Ubuntu 24.04#4278
ansible: update benchmark/v8 roles for Ubuntu 24.04#4278richardlau wants to merge 2 commits intonodejs:mainfrom
Conversation
Add role dependencies to the `benchmarking` role to ensure the user is created and github.com keys are present. Add V8 build dependencies for Ubuntu 24.04.
|
Needs more work. https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/770/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/console is failing with which was seen in #4079 (comment) with Python 3.12 and solved by dropping down to Python 3.11. |
|
Refs: https://issues.chromium.org/issues/40283283#comment49 FWIW As a data point I'm running https://ci.nodejs.org/job/richardlau-node-test-commit-v8-linux/771/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/ for nodejs/node#61898 and that appears to be working (or at least building). We have got a problem though -- the default Python 3 on Ubuntu 24.04 is 3.12 and there does not appear to be a package for 3.11 so we cannot use an earlier version. And we still need to be able to run the V8 CI on e.g. Node.js 22 and 24. |
FTR this got as far as nodejs/node#61898 (comment) (that comment mentions GCC < 14 but we're using clang19 here and seeing the same issue). |
|
Overriding diff --git a/tools/v8/fetch_deps.py b/tools/v8/fetch_deps.py
index 728e48eb14e..185972a90fd 100755
--- a/tools/v8/fetch_deps.py
+++ b/tools/v8/fetch_deps.py
@@ -24,6 +24,7 @@ GCLIENT_SOLUTION = [
"deps_file" : "DEPS",
"managed" : False,
"custom_deps" : {
+ "v8/third_party/depot_tools" : "https://chromium.googlesource.com/chromium/tools/depot_tools.git@284c5ccb591c3de4e9f71be4a4beb5d1916d5383",
# These deps are already part of Node.js.
"v8/base/trace_event/common" : None,
"v8/third_party/abseil-cpp" : None,we could alternatively directly modify @nodejs/v8-update @nodejs/releasers Any thoughts/preferences?
I don't remember if moving from Ubuntu 22.04 to 24.04 was toolchain related (@targos ?) which would make it impractical to stay on Ubuntu 22.04 (note that Python 3.11 there is a |
Yes, it was to get access to Clang 19+ |
Right, in which case staying on Ubuntu 22.04 is out of the question. @targos Do you have thoughts on overriding (either DEPS or fetch_deps.py) depot_tools in either the checked in source code (all release lines) or directly in the Jenkins job? (Or have other suggestions to try?) @ryanaslett was asking if the machine has to be Ubuntu, and I don't think it does, but would be more work to transition to something else (RHEL?). |
That sounds good to me. As long as it works, I would take the easiest to maintain route |
Add role dependencies to the
benchmarkingrole to ensure the user is created and github.com keys are present.Add V8 build dependencies for Ubuntu 24.04.
Deployment